linux-kernel - RE: [PATCH v2 2/2] dma/ep93xx_dma: prevent ep93xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADE657CA350FB648AAC2C43247A983F001F3E96DACDC@AUSP01VMBX24.collaborationhost.net>
Date:	Mon, 28 Nov 2011 11:33:04 -0600
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Mika Westerberg <mika.westerberg@....fi>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"rmallon@...il.com" <rmallon@...il.com>,
	Rafal Prylowski <prylowski@...asoft.pl>
Subject: RE: [PATCH v2 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to
 reference an empty list

On Saturday, November 26, 2011 3:54 AM, Mika Westerberg wrote:
> 
> If dma_terminate_all() is called before the ep93xx_dma_tasklet() gets to run,
> it tries to access an empty ->active list which results following OOPS:

[OOPS snipped...]

> To make the code a bit more robust against things like these, we modify
> ep93xx_dma_get_active() to return NULL in case of empty ->active list and make
> sure that callers handle this correctly.
> 
> Reported-by: Rafal Prylowski <prylowski@...asoft.pl>
> Signed-off-by: Mika Westerberg <mika.westerberg@....fi>
> ---
>  drivers/dma/ep93xx_dma.c |   60 ++++++++++++++++++++++++++++++++++++---------
>  1 files changed, 48 insertions(+), 12 deletions(-)

Looks good.  Thanks.

Acked-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/