linux-kernel - Re: [PATCH] watchdog: fix nowayout setting in s3c2410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111129102136.GB5455@pengutronix.de>
Date:	Tue, 29 Nov 2011 11:21:37 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Marc Vertes <marc.vertes@...fox.com>, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	Dimitry Andric <dimitry.andric@...tom.com>,
	Ben Dooks <ben@...tec.co.uk>
Subject: Re: [PATCH] watchdog: fix nowayout setting in s3c2410_wdt


> +/* Use the following function to set the nowayout feature */
> +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> +{
> +	if (nowayout)
> +		set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> +}

Yes, this is better in case we might need to add something later.

> but: .status = WATCHDOG_NOWAYOUT_INIT_STATUS, is also a nice one to have.
> 
> I propose to add both options and to document them in the documentation.
> Objections anyone?

Sounds good to me.

So, I'll drop NOWAYOUT-related patches from my STMP-series?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)