linux-kernel - Re: [PATCH] watchdog: fix nowayout setting in s3c2410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111129104452.GI23376@infomag.iguana.be>
Date:	Tue, 29 Nov 2011 11:44:52 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Marc Vertes <marc.vertes@...fox.com>, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	Dimitry Andric <dimitry.andric@...tom.com>,
	Ben Dooks <ben@...tec.co.uk>
Subject: Re: [PATCH] watchdog: fix nowayout setting in s3c2410_wdt

Hi Wolfram,

> > +/* Use the following function to set the nowayout feature */
> > +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> > +{
> > +	if (nowayout)
> > +		set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> > +}
> 
> Yes, this is better in case we might need to add something later.
> 
> > but: .status = WATCHDOG_NOWAYOUT_INIT_STATUS, is also a nice one to have.
> > 
> > I propose to add both options and to document them in the documentation.
> > Objections anyone?
> 
> Sounds good to me.
> 
> So, I'll drop NOWAYOUT-related patches from my STMP-series?

Yes, I'll make sure we do the necessary on the nowayout side :-). Will try to add a patch for it today.
Could you resend the SMTP series after that you dropped the nowayout patches so I can review these?

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/