linux-kernel - Re: [PATCH v3] ore: FIX breakage when MISC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED5E9E1.9050709@suse.cz>
Date:	Wed, 30 Nov 2011 09:31:29 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	NFS list <linux-nfs@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Benny Halevy <bhalevy@...ian.com>, linux-next@...r.kernel.org,
	open-osd <osd-dev@...n-osd.org>
Subject: Re: [PATCH v3] ore: FIX breakage when MISC_FILESYSTEMS is not set

Dne 30.11.2011 00:35, Boaz Harrosh napsal(a):
> 
> As Reported by Randy Dunlap
> 
> When MISC_FILESYSTEMS is not enabled:
> 
> fs/built-in.o: In function `objio_alloc_io_state':
> objio_osd.c:(.text+0xcb525): undefined reference to `ore_get_rw_state'
> fs/built-in.o: In function `_write_done':
> objio_osd.c:(.text+0xcb58d): undefined reference to `ore_check_io'
> fs/built-in.o: In function `_read_done':
> ...
> 
> When MISC_FILESYSTEMS, which is more of a GUI thing then anything else,
> is not selected. exofs/Kconfig is never examined during Kconfig,
> and it can not do it's magic stuff to automatically select everything
> needed.
> 
> We must split exofs/Kconfig in two. The ore one is always included.
> And the exofs one is left in it's old place in the menu.
> 
> Signed-off-by: Boaz Harrosh <bharrosh@...asas.com>
> ---
>  fs/Kconfig           |    2 ++
>  fs/exofs/Kconfig     |   11 -----------
>  fs/exofs/ore.Kconfig |   12 ++++++++++++
>  3 files changed, 14 insertions(+), 11 deletions(-)
>  create mode 100644 fs/exofs/ore.Kconfig
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 5f4c45d..fd7bfef 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -218,6 +218,8 @@ source "fs/exofs/Kconfig"
>  
>  endif # MISC_FILESYSTEMS
>  
> +source "fs/exofs/ore.Kconfig"
> +

I suggest you name it Kconfig.ore. We have a couple of Kconfig.* files
in the tree, so let's be consistent.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/