linux-kernel - Re: [PATCH RFC 0/5] uprobes: kill xol vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91601168bd8039233da8d91a07560f20.squirrel@www.firstfloor.org>
Date:	Wed, 30 Nov 2011 17:15:10 +0100
From:	"Andi Kleen" <andi@...stfloor.org>
To:	"Oleg Nesterov" <oleg@...hat.com>
Cc:	"Srikar Dronamraju" <srikar@...ux.vnet.ibm.com>,
	"Peter Zijlstra" <peterz@...radead.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Linux-mm" <linux-mm@...ck.org>, "Ingo Molnar" <mingo@...e.hu>,
	"Andi Kleen" <andi@...stfloor.org>,
	"Christoph Hellwig" <hch@...radead.org>,
	"Steven Rostedt" <rostedt@...dmis.org>,
	"Roland McGrath" <roland@...k.frob.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Masami Hiramatsu" <masami.hiramatsu.pt@...achi.com>,
	"Arnaldo Carvalho de Melo" <acme@...radead.org>,
	"Anton Arapov" <anton@...hat.com>,
	"Ananth N Mavinakayanahalli" <ananth@...ibm.com>,
	"Jim Keniston" <jkenisto@...ux.vnet.ibm.com>,
	"Stephen Wilson" <wilsons@...rt.ca>
Subject: Re: [PATCH RFC 0/5] uprobes: kill xol vma


>  static unsigned char
> -uprobe_xol_slots[UPROBES_XOL_SLOT_BYTES][NR_CPUS] __page_aligned_bss;
> +uprobe_xol_slots[NR_CPUS][UPROBES_XOL_SLOT_BYTES] __page_aligned_bss;

NR_CPUS arrays are basically always wrong.

Use per cpu data.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/