linux-kernel - RE: [PATCH 01/11] MFD: DA9052 MFD core module v8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C3AE124F08223B42BC95AEB82F0F6CED1F9CFD03@KCHJEXMB01.kpit.com>
Date:	Fri, 2 Dec 2011 13:57:49 +0000
From:	Ashish Jangam <Ashish.Jangam@...tcummins.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"sameo@...nedhand.com" <sameo@...nedhand.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dajun <dajun.chen@...semi.com>,
	"linaro-dev@...ts.linaro.org" <linaro-dev@...ts.linaro.org>
Subject: RE: [PATCH 01/11] MFD: DA9052 MFD core module v8

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: Thursday, November 24, 2011 5:36 PM
> To: Ashish Jangam
> Cc: arnd@...db.de; sameo@...nedhand.com; linux-kernel@...r.kernel.org;
> Dajun; linaro-dev@...ts.linaro.org
> Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v8
> 
> On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote:
> 
> > +	da9052_i2c->bustype = BUS_I2C;
> 
> bustype should be redundant now, it certianly doesn't seem to be
> referred to in this patch.
This is required in the TSI driver.
> 
> > +/*
> > + * Interrupt controller support for Dilaog DA9052 PMICs.
> 
> This looks very much like it could be replaced with regmap-irq.  The
> code would be slightly less efficient due to the support for sparse
> interrupt registers but it'd be less code.
regmap-irq has a opaque struct regmap_irq_chip_data which has a member
irq_base and this is required for non-primary irqs registration
and also the clean-up function regmap_del_irq_chip() requires it.
So as of now I will keep the current irq implementation as it is.