| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201112021400.42762.pedro@codesourcery.com> Date: Fri, 2 Dec 2011 14:00:42 +0000 From: Pedro Alves <pedro@...esourcery.com> To: Pavel Emelyanov <xemul@...allels.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Cyrill Gorcunov <gorcunov@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, Tejun Heo <tj@...nel.org>, Andrew Vagin <avagin@...nvz.org>, Serge Hallyn <serge.hallyn@...onical.com>, Vasiliy Kulikov <segoon@...nwall.com> Subject: Re: [rfc 2/3] fs, proc: Introduce the Children: line in /proc/<pid>/status On Friday 02 December 2011 13:52:43, Pavel Emelyanov wrote: > On 12/02/2011 05:44 PM, Pedro Alves wrote: > > On Friday 02 December 2011 13:16:52, Pavel Emelyanov wrote: > >> On 12/02/2011 04:58 PM, Pedro Alves wrote: > >>> On Friday 02 December 2011 12:43:10, Pavel Emelyanov wrote: > >>> > >>>>>> Yes, I like /children file. other points seems to be pointed out by other > >>>>>> reviewers. > >>>>> > >>>>> Any reason this is a file instead of a directory like /proc/PID/task/ ? > >>>>> > >>>>> $ sudo ls /proc/8167/task/ > >>>>> 8167 854 855 856 857 858 859 > >>>>> $ sudo ls /proc/8167/task/855/ > >>>>> attr clear_refs cpuset exe io loginuid mountinfo oom_adj pagemap sched smaps statm wchan > >>>>> auxv cmdline cwd fd latency maps mounts oom_score personality schedstat stack status > >>>>> cgroup comm environ fdinfo limits mem numa_maps oom_score_adj root sessionid stat syscall > >>>>> > >>>>> Much easier to follow the chain from the command line this way. > >>>> > >>>> What do you propose to put into these directories? Another directories named with > >>>> children pid-s? > >>> > >>> Yes, just like the task/ dir gives you directories named with the > >>> processes's thread ids. Opening /proc/PID/children/PID-CHILD1/ would get > >>> you the same as opening /proc/PID-CHILD1/. Just like > >>> opening /proc/PID/task/PID-CHILD1/ gets you (almost) the same as opening > >>> /proc/PID-CHILD1/. > >> > >> You cannot make the dentry named /proc/<pid1>/children/<pid2> be a hardlink on > >> the /proc/<pid2>. Thus you have to make arbitrary amount of inodes to point to > >> a single task. This brings unnecessary complexity and memory usage (by dentries > >> and proc inodes). > > > > How is this different from the _already existing_ /proc/<pid1>/task/ directory? > > Those living in /proc/<pid1>/task do not live in /proc. At all. This explains > everything below. Well, except they do, and it doesn't. The're not visible when listing /proc/, but they're there. Try it. $ls /proc/ | grep 854 (empty) $ ls /proc/8167/task/854 attr clear_refs cpuset exe io loginuid mountinfo oom_adj pagemap sched smaps statm wchan auxv cmdline cwd fd latency maps mounts oom_score personality schedstat stack status cgroup comm environ fdinfo limits mem numa_maps oom_score_adj root sessionid stat syscall $ls /proc/854/ attr cgroup comm cwd fd latency maps mounts numa_maps oom_score_adj root sessionid stat syscall autogroup clear_refs coredump_filter environ fdinfo limits mem mountstats oom_adj pagemap sched smaps statm task auxv cmdline cpuset exe io loginuid mountinfo net oom_score personality schedstat stack status wchan -- Pedro Alves -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists