linux-kernel - Re: [PATCH 1/2] virtio-scsi: first version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322950969.11728.24.camel@pasglop>
Date:	Sun, 04 Dec 2011 09:22:49 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] virtio-scsi: first version

On Sat, 2011-12-03 at 18:38 +0100, Paolo Bonzini wrote:
> On 12/03/2011 12:07 AM, Benjamin Herrenschmidt wrote:
> > This is typically the one thing you should -really- obtain from the
> > other side. This is the number one reason why we cannot today reliably
> > emulate a SCSI controller in qemu -and- pass-through the SCSI commands
> > to the host /dev/sg or equivalent (only full device emulation is
> > reliable).
> >
> > This is also typically what something like virtio-scsi allows us to fix,
> > so let's fix it. IE. we have the ability to query the "limits" of the
> > real HBA /  transport on the host side and to pass them along to the
> > guest, which enables us to do real pass-through.
> 
> You can fix this in QEMU; READ and WRITE commands can be split in 
> multiple parts.  The scsi-block device I added recently does this.

You can split -some- commands... it's clumsy and not always legit, you
don't always know all commands (what about vendor commands such as
firmware updates etc...) and it can be really tricky with tagged queues
and barriers.

> However, it seems like a simple change, so I'll do it.  I'll add 
> max_sectors and cmd_per_lun to the config space.

Sounds like a good start :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/