linux-kernel - Re: [PATCH] scsi/sym53c8xx_2: Fix NULL pointer dereference in slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EDBB02F.8070106@gentoo.org>
Date:	Sun, 04 Dec 2011 19:38:55 +0200
From:	Stratos Psomadakis <psomas@...too.org>
To:	linux-scsi@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	JBottomley@...allels.com, matthew@....cx, Martin.vGagern@....net
Subject: Re: [PATCH] scsi/sym53c8xx_2: Fix NULL pointer dereference in slave_destroy

On 12/04/2011 02:23 AM, psomas@...too.org wrote:
> From: Stratos Psomadakis <psomas@...too.org>
>
> sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has
> succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference
> (exposed by commit 4e6c82b).
>
> Signed-off-by: Stratos Psomadakis <psomas@...too.org>
> Cc: stable@...r.kernel.org
Reported-by:  Martin von Gagern <Martin.vGagern@....net>
Tested-by: Martin von Gagern <Martin.vGagern@....net>

> ---
>
>  drivers/scsi/sym53c8xx_2/sym_glue.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
> index b4543f5..76432f8 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
> +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
> @@ -839,6 +839,10 @@ static void sym53c8xx_slave_destroy(struct scsi_device *sdev)
>  	struct sym_lcb *lp = sym_lp(tp, sdev->lun);
>  	unsigned long flags;
>  
> +	/* if slave_alloc returned before allocating a sym_lcb, return */
> +	if (!lp)
> +		return;
> +
>  	spin_lock_irqsave(np->s.host->host_lock, flags);
>  
>  	if (lp->busy_itlq || lp->busy_itl) {
-- 
Stratos Psomadakis
<psomas@...too.org>



Download attachment "signature.asc" of type "application/pgp-signature" (263 bytes)