linux-kernel - Re: [PATCH 3/3] staging: vt6655: card.c, srom.c, vntwifi.c: Code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1112042000070.5963@cactuar.localhost>
Date:	Sun, 4 Dec 2011 20:01:39 -0200 (BRST)
From:	Marcos Paulo de Souza <marcos.mage@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH 3/3] staging: vt6655: card.c, srom.c, vntwifi.c: Code
 cleanup

On Sat, 3 Dec 2011, Dan Carpenter wrote:
> On Fri, Dec 02, 2011 at 07:58:12PM +0000, Marcos Paulo de Souza wrote:
>> This patch removes commented code, useless comments, blank lines and fix
>> coding style of the headers of functions.
>>
>> Signed-off-by: Marcos Paulo de Souza <marcos.mage@...il.com>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>> Cc: devel@...verdev.osuosl.org
>> ---
>>  /*
>> - * Description: Test if bits off in eeprom
>> - *
>> - * Parameters:
>> - *  In:
>> - *      dwIoBase        - I/O base address
>> - *      byContntOffset  - address of EEPROM
>> - *      byTestBits      - bits to test
>> - *  Out:
>> - *      none
>> - *
>> - * Return Value: true if all test bits off; otherwise false
>> - *
>> + * Test if bits off in eeprom
>>   */
>
> Some of these seems sort of useful.  It might be better to change
> them to doc-book format instead of deleting them:
>
> /**
> * SROMbIsRegBitsOff() - Test if bits off in eeprom
> * @dwIoBase:       I/O base address
> * @byContntOffset: Address of EEPROM
> * @byTestBits:     Bits to test
> *
> * Returns true if all test bits off; otherwise false.
> */
>
> There is a howto in Documentation/kernel-doc-nano-HOWTO.txt.

Thanks for the suggestion Dan. I will do it for these 3 patches.

Greg, please delte this patches, I will sent them again.

Regards,

Marcos Paulo de Souza

> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/