[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4EDF5231.6080309@bitmer.com>
Date: Wed, 07 Dec 2011 13:46:57 +0200
From: Jarkko Nikula <jarkko.nikula@...mer.com>
To: Felipe Contreras <felipe.contreras@...il.com>
CC: Felipe Contreras <felipe.contreras@...ia.com>,
linux-main <linux-kernel@...r.kernel.org>,
Kalle Jokiniemi <kalle.jokiniemi@...ia.com>,
Heikki Krogerus <heikki.krogerus@...ia.com>,
Anton Vorontsov <cbouatmailru@...il.com>,
Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"
On 12/05/2011 07:31 PM, Felipe Contreras wrote:
> Should probably have CC'ed linux-omap.
>
> On Mon, Dec 5, 2011 at 7:23 PM, Felipe Contreras
> <felipe.contreras@...ia.com> wrote:
>> From: Felipe Contreras<felipe.contreras@...il.com>
>>
>> This reverts commit 10299e2e4e3ed3b16503d4e04edd48b33083f4e2.
>>
>> This seems to break USB networking stuff.
>>
I don't think revert is needed since CONFIG_CHARGER_ISP1704=y should
make it working. Although I don't know do we really need to drive the
ISP1704 into reset in board-rx51-peripherals.c? Would it be better to
leave gpio state as it was set by the bootloader and let the driver to
do reset sequence if needed?
http://marc.info/?l=linux-omap&m=130795363204884&w=2
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists