linux-kernel - Re: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111207130517.GA22946@xps8300>
Date:	Wed, 7 Dec 2011 15:05:17 +0200
From:	Heikki Krogerus <krohei@...il.com>
To:	Felipe Contreras <felipe.contreras@...ia.com>
Cc:	linux-main <linux-kernel@...r.kernel.org>,
	Kalle Jokiniemi <kalle.jokiniemi@...ia.com>,
	Heikki Krogerus <heikki.krogerus@...ia.com>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Felipe Contreras <felipe.contreras@...il.com>
Subject: Re: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"

Hi,

On Mon, Dec 05, 2011 at 07:23:40PM +0200, Felipe Contreras wrote:
> From: Felipe Contreras <felipe.contreras@...il.com>
> 
> This reverts commit 10299e2e4e3ed3b16503d4e04edd48b33083f4e2.
> 
> This seems to break USB networking stuff.
> 
> Cc: Kalle Jokiniemi <kalle.jokiniemi@...ia.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ia.com>
> Cc: Anton Vorontsov <cbouatmailru@...il.com>
> Cc: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c |   27 +------------------------
>  1 files changed, 2 insertions(+), 25 deletions(-)

<snip>

> -static void __init rx51_charger_init(void)
> -{
> -	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> -		GPIOF_OUT_INIT_LOW, "isp1704_reset"));

How about simply GPIOF_OUT_INIT_HIGH here. Is that not enough to fix
your problem? Revering the whole thing does not make any sense to me.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/