linux-kernel - Re: linux-next: Tree for Dec 7 (x86, not SMP)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111207210630.GI1669@redhat.com>
Date:	Wed, 7 Dec 2011 16:06:30 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for Dec 7 (x86, not SMP)

On Wed, Dec 07, 2011 at 12:43:37PM -0800, Randy Dunlap wrote:
> On 12/07/2011 11:42 AM, Don Zickus wrote:
> > On Wed, Dec 07, 2011 at 11:10:29AM -0800, Randy Dunlap wrote:
> >> On 12/06/2011 10:12 PM, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20111206:
> >>
> >>
> >> When CONFIG_SMP is not enabled:
> >> (I think that's the cause, but it could be some other kconfig option.)
> > 
> > Yeah it doesn't seem to be that one.  I think it is CONFIG_X86_LOCAL_APIC,
> > but I can't quickly figure out how to disable it (it keeps getting
> > re-enabled somewhere).
> > 
> > Can you attach your .config?
> 
> Certainly. Done.
> Thanks.

Ok, I was right it does depend on the local apic.  The following patch
fixed the problem for me.

Cheers,
Don 
-----8<----

From: Don Zickus <dzickus@...hat.com>
Date: Wed, 7 Dec 2011 16:03:40 -0500
Subject: [PATCH] x86, NMI: NMI selftest depends on the local apic

The selftest doesn't work with out a local apic for now.

Reported-by: Randy Durlap <rdunlap@...otime.net>
Signed-off-by: Don Zickus <dzickus@...hat.com>
---
 arch/x86/Kconfig.debug |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 020a4f1..d6eea6d 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -286,7 +286,7 @@ config DEBUG_STRICT_USER_COPY_CHECKS
 
 config DEBUG_NMI_SELFTEST
 	bool "NMI Selftest"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && X86_LOCAL_APIC
 	---help---
 	  Enabling this option turns on a quick NMI selftest to verify
 	  that the NMI behaves correctly.
-- 
1.7.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/