linux-kernel - Re: [PATCH] HID: wiimote: Select INPUT_FF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b92a2d1d30910b75f3354926d9fa26f6.squirrel@host171.canaca.com>
Date:	Wed, 7 Dec 2011 16:07:38 -0500
From:	simon@...gewell.org
To:	"David Herrmann" <dh.herrmann@...glemail.com>
Cc:	linux-input@...r.kernel.org, rdunlap@...otime.net,
	linux-next@...r.kernel.org, jkosina@...e.cz,
	linux-kernel@...r.kernel.org,
	"David Herrmann" <dh.herrmann@...glemail.com>
Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS


> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index edf2b2b..dae04a0 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -591,6 +591,7 @@ config HID_WIIMOTE
>  	depends on BT_HIDP
>  	depends on LEDS_CLASS
>  	select POWER_SUPPLY
> +	select INPUT_FF_MEMLESS
>  	---help---
>  	Support for the Nintendo Wii Remote bluetooth device.

I don't mean to be a complainer, but shouldn't the WiiMote module depend
on FF_MEMLESS rather than just forcing it on.

The module could also #define the appropriate bits so that FF_MEMLESS was
only used when available, the rumble motor is a very small part of the
WiiMote's feature set.

Some people might not want FF_MEMLESS enabled.
Simon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/