linux-kernel - Re: [PATCH] HID: wiimote: Select INPUT_FF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Dec 2011 09:31:20 +0100
From:	David Herrmann <dh.herrmann@...glemail.com>
To:	simon@...gewell.org
Cc:	linux-input@...r.kernel.org, rdunlap@...otime.net,
	linux-next@...r.kernel.org, jkosina@...e.cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS

On Wed, Dec 7, 2011 at 10:07 PM,  <simon@...gewell.org> wrote:
>
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index edf2b2b..dae04a0 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -591,6 +591,7 @@ config HID_WIIMOTE
>>       depends on BT_HIDP
>>       depends on LEDS_CLASS
>>       select POWER_SUPPLY
>> +     select INPUT_FF_MEMLESS
>>       ---help---
>>       Support for the Nintendo Wii Remote bluetooth device.
>
> I don't mean to be a complainer, but shouldn't the WiiMote module depend
> on FF_MEMLESS rather than just forcing it on.

I have considered that but "grep -r FF_MEMLESS" returned no other
driver using "depend" so I decided to use "select", too.

> The module could also #define the appropriate bits so that FF_MEMLESS was
> only used when available, the rumble motor is a very small part of the
> WiiMote's feature set.
>
> Some people might not want FF_MEMLESS enabled.

Why? It is a really small feature that depends only on CONFIG_INPUT.
Just 600 lines of code. I don't see why someone who wants to enable
the way bigger wiimote driver and HID core would bother about
FF_MEMLESS? Why should someone want to disable the rumble-feature of
the wiimote?
I cannot see any real use-case here. Maybe you can explain a bit more.

> Simon.
>

Cheers
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/