linux-kernel - Re: [PATCH] HID: wiimote: Select INPUT_FF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80063840e8a9778675e9a63db6f1d956.squirrel@host171.canaca.com>
Date:	Thu, 8 Dec 2011 11:23:26 -0500
From:	simon@...gewell.org
To:	"David Herrmann" <dh.herrmann@...glemail.com>
Cc:	simon@...gewell.org, linux-input@...r.kernel.org,
	rdunlap@...otime.net, linux-next@...r.kernel.org, jkosina@...e.cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS


>> I don't mean to be a complainer, but shouldn't the WiiMote module depend
>> on FF_MEMLESS rather than just forcing it on.
>
> I have considered that but "grep -r FF_MEMLESS" returned no other
> driver using "depend" so I decided to use "select", too.

If you look at 'Kconfig' every other driver is fragmented into a 'driver'
and 'driver_ff', it is only the 'driver_ff' bit which does the
force-feedback and all the 'drivers' would appear to work OK (as pure
input devices) with FF disabled.

Someone here will be able to comment whether that is policy, convention or
just historic....

>> Some people might not want FF_MEMLESS enabled.
>
> Why? It is a really small feature that depends only on CONFIG_INPUT.
> Just 600 lines of code. I don't see why someone who wants to enable
> the way bigger wiimote driver and HID core would bother about
> FF_MEMLESS? Why should someone want to disable the rumble-feature of
> the wiimote?

600 lines where? What's the other costs to the system when enabling the FF
code in the kernel.

> I cannot see any real use-case here. Maybe you can explain a bit more.

Again I'm not here to kick up a fuss; it just looked different from the
norm, so I was flagging it.

Simon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/