linux-kernel - Re: [PATCH 06/10] HWMON: Convert coretemp to x86 cpuid autoprobing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111208171303.796aa673@endymion.delvare>
Date:	Thu, 8 Dec 2011 17:13:03 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	guenter.roeck@...csson.com
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Kay Sievers <kay.sievers@...y.org>, trenn@...e.de,
	Andi Kleen <ak@...ux.intel.com>, fenghua.yu@...el.com
Subject: Re: [PATCH 06/10] HWMON: Convert coretemp to x86 cpuid autoprobing

On Thu, 8 Dec 2011 08:09:29 -0800, Guenter Roeck wrote:
> On Thu, 2011-12-08 at 02:24 -0500, Jean Delvare wrote:
> > Hi Andi,
> > 
> > Thanks a lot for working on this. I wanted to give it a try long ago but
> > could never find the time.
> > 
> > On Wed, 7 Dec 2011 18:40:01 -0800, Guenter Roeck wrote:
> > > Andi,
> > > 
> > > On Wed, Dec 07, 2011 at 07:41:19PM -0500, Andi Kleen wrote:
> > > > From: Andi Kleen <ak@...ux.intel.com>
> > > > 
> > > > Use the new x86 cpuid autoprobe interface for the Intel coretemp
> > > > driver.
> > > > 
> > > > Cc: fenghua.yu@...el.com
> > > > Cc: khali@...ux-fr.org
> > > > Cc: guenter.roeck@...csson.com
> > > > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> > > > ---
> > > >  drivers/hwmon/coretemp.c |   17 ++++++++++++++---
> > > >  1 files changed, 14 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > > > index 104b376..5de1579 100644
> > > > --- a/drivers/hwmon/coretemp.c
> > > > +++ b/drivers/hwmon/coretemp.c
> > > > @@ -39,6 +39,7 @@
> > > >  #include <linux/moduleparam.h>
> > > >  #include <asm/msr.h>
> > > >  #include <asm/processor.h>
> > > > +#include <asm/cpu_device_id.h>
> > > >  
> > > >  #define DRVNAME	"coretemp"
> > > >  
> > > > @@ -756,13 +757,23 @@ static struct notifier_block coretemp_cpu_notifier __refdata = {
> > > >  	.notifier_call = coretemp_cpu_callback,
> > > >  };
> > > >  
> > > > +static struct x86_cpu_id coretemp_ids[] = {
> > 
> > Can't this be made const?
> > 
> Unless I am missing something, the patchset would have to change to
> accept a const as parameter to x86_match_cpu().

Yes, I proposed that too in my review of the relevant patch.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/