lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 11 Dec 2011 20:59:39 +0000
From:	Al Viro <>
To:	Vasiliy Kulikov <>
Cc:	Andrew Morton <>,
	Alexey Dobriyan <>,,,
	Hugh Dickins <>
Subject: Re: [PATCH -next] proc: fix task_struct infoleak

On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> access.  A demo from Hugh Dickins:
> while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> Reported-by: Hugh Dickins <>
> Signed-off-by: Vasiliy Kulikov <>
> ---
>  This is a patch against a hidepid patchset from -mm.

Choose saner commit summary, please.  It's not information leak, for pity sake
- it's a plain and simple memory leak...

Speaking of which, I've a couple of memory leaks in mainline procfs and
mqueue; Alexey, are you OK with that sucker going directly to Linus or
would you rather push it yourself?  See the patch below...

diff --git a/fs/proc/root.c b/fs/proc/root.c
index 9a8a2b7..03102d9 100644
--- a/fs/proc/root.c
+++ b/fs/proc/root.c
@@ -91,20 +91,18 @@ static struct file_system_type proc_fs_type = {
 void __init proc_root_init(void)
-	struct vfsmount *mnt;
 	int err;
 	err = register_filesystem(&proc_fs_type);
 	if (err)
-	mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
-	if (IS_ERR(mnt)) {
+	err = pid_ns_prepare_proc(&init_pid_ns);
+	if (err) {
-	init_pid_ns.proc_mnt = mnt;
 	proc_symlink("mounts", NULL, "self/mounts");
@@ -209,5 +207,5 @@ int pid_ns_prepare_proc(struct pid_namespace *ns)
 void pid_ns_release_proc(struct pid_namespace *ns)
-	mntput(ns->proc_mnt);
+	kern_unmount(ns->proc_mnt);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists