linux-kernel - Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111212100513.GA5017@sirena.org.uk>
Date:	Mon, 12 Dec 2011 10:05:14 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org, Lars-Peter Clausen <lars@...afoo.de>,
	Mike Frysinger <vapier@...too.org>, qi.wang@...el.com,
	Takashi Iwai <tiwai@...e.de>, linux-kernel@...r.kernel.org,
	yong.y.wang@...el.com, kok.howg.ewe@...el.com,
	Daniel Mack <zonque@...il.com>, Liam Girdwood <lrg@...com>,
	joel.clark@...el.com
Subject: Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

On Mon, Dec 12, 2011 at 05:28:13PM +0900, Tomoya MORINAGA wrote:

> struct snd_soc_ops {
> ...
> };

> On the other hand, tegra_i2s.c describes like below.

> static const struct snd_soc_dai_ops tegra_i2s_dai_ops = {
> ...
> };

> Which is true as modern driver ? or case by case ?

The latter.  With things like this it would be *really* helpful if you
could take a step back and think about what the differences mean and why
they are different.

> 
> >> +#define      I2S_CH0_MCLK            (12288000) /* Master Clock Frequency[Hz] */
> > This looks like it should be board specific?
> Should our platform driver use "clk_get()" ?
> If no, how should our driver get the value ?

Again, with things like this it would be really helpful if you could
attempt to answer questions for yourself.  Have you looked at how other
platforms configure clock rates from machine drivers?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/