linux-kernel - Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQng7AgKLYGSbBMbOiWifL6WNPHM=b7cB0FhfuXg74qi1Fg@mail.gmail.com>
Date:	Tue, 13 Dec 2011 13:38:25 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org, Lars-Peter Clausen <lars@...afoo.de>,
	Mike Frysinger <vapier@...too.org>, qi.wang@...el.com,
	Takashi Iwai <tiwai@...e.de>, linux-kernel@...r.kernel.org,
	yong.y.wang@...el.com, kok.howg.ewe@...el.com,
	Daniel Mack <zonque@...il.com>, Liam Girdwood <lrg@...com>,
	joel.clark@...el.com
Subject: Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

2011/12/12 Mark Brown <broonie@...nsource.wolfsonmicro.com>:
> On Mon, Dec 12, 2011 at 05:28:13PM +0900, Tomoya MORINAGA wrote:
>
>> struct snd_soc_ops {
>> ...
>> };
>
>> On the other hand, tegra_i2s.c describes like below.
>
>> static const struct snd_soc_dai_ops tegra_i2s_dai_ops = {
>> ...
>> };
>
>> Which is true as modern driver ? or case by case ?
>
> The latter.  With things like this it would be *really* helpful if you
> could take a step back and think about what the differences mean and why
> they are different.

Our driver needs ".pointer" method.
However, "struct snd_soc_dai_ops" doesn't have the method.
So, I think "struct snd_soc_dai_ops" cannot be applied to our driver.
Searching other drivers, "blackfin/bf5xx-i2s-pcm.c" uses "struct
snd_soc_ops" not "struct snd_soc_dai_ops".
Let me know your opinion.

Thanks,

tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/