linux-kernel - Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111213045958.GC4565@opensource.wolfsonmicro.com>
Date:	Tue, 13 Dec 2011 12:59:59 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org, Lars-Peter Clausen <lars@...afoo.de>,
	Mike Frysinger <vapier@...too.org>, qi.wang@...el.com,
	Takashi Iwai <tiwai@...e.de>, linux-kernel@...r.kernel.org,
	yong.y.wang@...el.com, kok.howg.ewe@...el.com,
	Daniel Mack <zonque@...il.com>, Liam Girdwood <lrg@...com>,
	joel.clark@...el.com
Subject: Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver

On Tue, Dec 13, 2011 at 01:38:25PM +0900, Tomoya MORINAGA wrote:
> 2011/12/12 Mark Brown <broonie@...nsource.wolfsonmicro.com>:

> > The latter.  With things like this it would be *really* helpful if you
> > could take a step back and think about what the differences mean and why
> > they are different.

> Our driver needs ".pointer" method.
> However, "struct snd_soc_dai_ops" doesn't have the method.
> So, I think "struct snd_soc_dai_ops" cannot be applied to our driver.

What makes you claim this - *why* does your DAI driver need a pointer
method?

> Searching other drivers, "blackfin/bf5xx-i2s-pcm.c" uses "struct
> snd_soc_ops" not "struct snd_soc_dai_ops".
> Let me know your opinion.

Of course the DMA driver uses the ops for DMA drivers!  Alternatively if
your question above is about your DMA driver then why is your DMA driver
using DAI ops?

To repeat what I said above in a different way *please* put more effort
into understanding things and trying to solve problems for yourself, or
improving the way you ask questions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/