linux-kernel - Re: [PATCH 1/1] scsi: retrieve cache mode using ATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323766382.8163.12.camel@dabdike>
Date:	Tue, 13 Dec 2011 12:53:02 +0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	Amit Sahrawat <amit.sahrawat83@...il.com>,
	Nam-Jae Jeon <namjae.jeon@...sung.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal
 routine fails

On Tue, 2011-12-13 at 09:20 +0900, Namjae Jeon wrote:
> > This whole patch looks like a layering violation.  Why not just update
> > the SAT layer to translate the MODE SENSE correctly?
> Would plz you explain more ? I didn't clearly understand your point yet.

The ATA layer does translation for SCSI commands.  Just translate the
mode sense correctly to use IDENTIFY word 85.  It's a smaller patch and
no need for any changes in SCSI.

Actually, looking at it, it seems to be correct ... why is it not
working for you?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/