linux-kernel - Re: [PATCH 1/1] scsi: retrieve cache mode using ATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADDb1s1-bvwMBNh8k7MYDcWjgk694zFhFd5=6XZC8WgKJccyLQ@mail.gmail.com>
Date:	Tue, 13 Dec 2011 17:45:47 +0530
From:	Amit Sahrawat <amit.sahrawat83@...il.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	Namjae Jeon <linkinjeon@...il.com>,
	Nam-Jae Jeon <namjae.jeon@...sung.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal
 routine fails

On Tue, Dec 13, 2011 at 2:23 PM, James Bottomley
<James.Bottomley@...senpartnership.com> wrote:
> On Tue, 2011-12-13 at 09:20 +0900, Namjae Jeon wrote:
>> > This whole patch looks like a layering violation.  Why not just update
>> > the SAT layer to translate the MODE SENSE correctly?
>> Would plz you explain more ? I didn't clearly understand your point yet.
>
> The ATA layer does translation for SCSI commands.  Just translate the
> mode sense correctly to use IDENTIFY word 85.  It's a smaller patch and
> no need for any changes in SCSI.
I have a confusion to this, can you please guide where exactly to look for this.
Is there any existing solution to this problem? I did a lot of
analysis and actually tried to make use of a number of USB HDD's from
different vendors to be very sure of my observations. Our's is a
target where-in we connect our HDD through the USB interface.
Do you mean that putting code changes at this place would have impact
on SATA HDD?
Please help more on this.
>
> Actually, looking at it, it seems to be correct ... why is it not
> working for you?
Again, if possible please share that code point, We can again check if
that is hitting in our case.
If need be I can provide the list of all the HDDs with their
manufaturer ID's - on which we tested.
Please let me know for this.
>
> James
>
>
Thanks & Regards,
Amit Sahrawat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/