linux-kernel - Re: [PATCH 1/1] scsi: retrieve cache mode using ATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EE7B7B9.7060700@garzik.org>
Date:	Tue, 13 Dec 2011 15:38:17 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Namjae Jeon <linkinjeon@...il.com>,
	Amit Sahrawat <amit.sahrawat83@...il.com>,
	Nam-Jae Jeon <namjae.jeon@...sung.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal
 routine fails

On 12/13/2011 03:53 AM, James Bottomley wrote:
> On Tue, 2011-12-13 at 09:20 +0900, Namjae Jeon wrote:
>>> This whole patch looks like a layering violation.  Why not just update
>>> the SAT layer to translate the MODE SENSE correctly?
>> Would plz you explain more ? I didn't clearly understand your point yet.
>
> The ATA layer does translation for SCSI commands.  Just translate the
> mode sense correctly to use IDENTIFY word 85.  It's a smaller patch and
> no need for any changes in SCSI.

Correct.

> Actually, looking at it, it seems to be correct ... why is it not
> working for you?

Indeed -- the patch attempts to address a problem that the libata-scsi 
translation module already handles.

I would look at why the device is not properly reporting that already. 
If necessary, we would update libata not SCSI.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/