linux-kernel - Re: [PATCH 1/2 v2] serial: bfin-uart: Enable hardware automatic CTS only when CTS pin is available.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 16:03:02 -0800
From:	Greg KH <greg@...ah.com>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-serial@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 1/2 v2] serial: bfin-uart: Enable hardware automatic CTS
 only when CTS pin is available.

On Mon, Dec 12, 2011 at 02:59:50PM +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> ---
>  drivers/tty/serial/bfin_uart.c |   19 ++++++++++---------
>  1 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/bfin_uart.c b/drivers/tty/serial/bfin_uart.c
> index abac237..a6c1c08 100644
> --- a/drivers/tty/serial/bfin_uart.c
> +++ b/drivers/tty/serial/bfin_uart.c
> @@ -726,16 +726,17 @@ static int bfin_serial_startup(struct uart_port *port)
>  	}
>  #endif
>  #ifdef CONFIG_SERIAL_BFIN_HARD_CTSRTS
> -	if (uart->cts_pin >= 0 && request_irq(uart->status_irq,
> -		bfin_serial_mctrl_cts_int,
> -		0, "BFIN_UART_MODEM_STATUS", uart)) {
> -		uart->cts_pin = -1;
> -		pr_info("Unable to attach BlackFin UART Modem Status interrupt.\n");
> -	}
> +	if (uart->cts_pin >= 0) {
> +		if (request_irq(uart->status_irq, bfin_serial_mctrl_cts_int,
> +			IRQF_DISABLED, "BFIN_UART_MODEM_STATUS", uart)) {
> +			uart->cts_pin = -1;
> +			pr_info("Unable to attach BlackFin UART Modem Status interrupt.\n");

Please use dev_info() here instead, that properly identifies the exact
device you are having problems with.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/