linux-kernel - RE: [PATCH V2 2/2] ARM: mmp: enable pinmux in platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1751860C3C@HQMAIL01.nvidia.com>
Date:	Tue, 13 Dec 2011 15:07:08 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...vell.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"eric.y.miao@...il.com" <eric.y.miao@...il.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"arnd@...db.de" <arnd@...db.de>
Subject: RE: [PATCH V2 2/2] ARM: mmp: enable pinmux in platform driver

Linus Walleij wrote at Tuesday, December 13, 2011 4:02 PM:
> On Tue, Dec 13, 2011 at 10:40 AM, Haojian Zhuang wrote:
...
> > +static struct pinmux_map brownstone_pmx_map[] = {
> > +       {
> > +               .name = "dkin",
> > +               .ctrl_dev_name = "mmp2-pinmux",
> > +               .function = "dkin",
> > +               .group = "dkin-2-pin",
> > +               .hog_on_boot = true,
> > +       }, {
...
> 
> Looks like we want to add
> #define PINMUX_MAP_SYS_HOG_GROUP() or so with four
> arguments, what do you say Stephen? Shall I try to patch  in
> something like that (then this patch will look even better).

Yes, sounds like a good idea. I just realized that I ignored PINMUX_MAP_*
in the stuff I'm working on and implemented exactly that macro as a custom
macro right before the map array. So, having it in the pinctrl header
would be good. 

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/