linux-kernel - Re: [PATCH V2 1/2] pinctrl: enable pinmux for pxa series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201112141540.49243.arnd@arndb.de>
Date:	Wed, 14 Dec 2011 15:40:49 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Haojian Zhuang <haojian.zhuang@...vell.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"eric.y.miao@...il.com" <eric.y.miao@...il.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>
Subject: Re: [PATCH V2 1/2] pinctrl: enable pinmux for pxa series

On Tuesday 13 December 2011, Stephen Warren wrote:
> Haojian Zhuang wrote at Tuesday, December 13, 2011 2:41 AM:
> 
> > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> 
> > +obj-$(CONFIG_PINMUX_PXA168)	+= pinmux-pxa168.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA300)	+= pinmux-pxa300.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA910)	+= pinmux-pxa910.o pinctrl-pxa3xx.o
> 
> That structure will cause problems if multiple of those Kconfig options
> are enabled at once, as in a multi-SoC kernel. Instead, shouldn't this be:
> 
> obj-$(CONFIG_PINCTRL_PXA3XX)	+= pinctrl-pxa3xx.o
> obj-$(CONFIG_PINMUX_PXA168)	+= pinmux-pxa168.o
> obj-$(CONFIG_PINMUX_PXA300)	+= pinmux-pxa300.o
> obj-$(CONFIG_PINMUX_PXA910)	+= pinmux-pxa910.o

I'm pretty sure the first version is ok too, as long as none of the
options can be built as modules.  Your version seems to be more common though.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/