linux-kernel - Re: [PATCH] Put braces around potentially empty 'if' body in handle_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1324167535.3323.63.camel@edumazet-laptop>
Date:	Sun, 18 Dec 2011 01:18:55 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michel Lespinasse <walken@...gle.com>,
	Hugh Dickins <hughd@...gle.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] Put braces around potentially empty 'if' body in
 handle_pte_fault()

Le dimanche 18 décembre 2011 à 01:03 +0100, Jesper Juhl a écrit :
> If one builds the kernel with -Wempty-body one gets this warning:
> 
>   mm/memory.c:3432:46: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> 
> due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
> can sometimes be defined to nothing.
> 
> I suggest we heed gcc's advice and put a pair of braces on that if.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  mm/memory.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 829d437..9cf1b48 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm,
>  		 * This still avoids useless tlb flushes for .text page faults
>  		 * with threads.
>  		 */
> -		if (flags & FAULT_FLAG_WRITE)
> +		if (flags & FAULT_FLAG_WRITE) {
>  			flush_tlb_fix_spurious_fault(vma, address);
> +		}
>  	}
>  unlock:
>  	pte_unmap_unlock(pte, ptl);
> -- 
> 1.7.8
> 

Thats should be fixed in the reverse way :

#define flush_tlb_fix_spurious_fault(vma, address) do { } while (0)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/