linux-kernel - Re: [PATCH 4/15] vub300: fix module parameter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1324300120.4283.6.camel@study-2>
Date:	Mon, 19 Dec 2011 13:08:40 +0000
From:	Tony Olech <tony.olech@...ndigitalsystems.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>, Chris Ball <cjb@...top.org>,
	linux-mmc@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/15] vub300: fix module parameter.

On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote:
> You didn't mean this to be a bool.
> 
> Cc: Tony Olech <tony.olech@...ndigitalsystems.com>
> Cc: Chris Ball <cjb@...top.org>
> Cc: linux-mmc@...r.kernel.org
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> ---
>  drivers/mmc/host/vub300.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
>  static int firmware_rom_wait_states = 0x1C;
>  #endif
>  
> -module_param(firmware_rom_wait_states, bool, 0644);
> +module_param(firmware_rom_wait_states, int, 0644);
>  MODULE_PARM_DESC(firmware_rom_wait_states,
>  		 "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
>  
> --
You are right.
I don't know how that slipped through
Acked-by: Tony Olech <tony.olech@...ndigitalsystems.com>
Acked-by: Tony Olech <tony@...ch.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/