linux-kernel - Re: [PATCH] sysfs: change permissions for /sys from 0755 to 0555

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m162hdmgul.fsf@fess.ebiederm.org>
Date:	Sun, 18 Dec 2011 18:32:18 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Vitaly Kuznetsov <vitty@...linux.ru>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysfs: change permissions for /sys from 0755 to 0555

Vitaly Kuznetsov <vitty@...linux.ru> writes:

> There is a misleading difference between /proc and /sys permissions, /proc is
> 0555 and /sys is 0755. But
> as it is impossible to create or unlink something in /sys it would be nice to
> have same permissions.

Where does this difference matter?  This doesn't look like something
that could matter in practice.  If this does matter in practice this
change deserves a comment and a fuller explanation.

The change itself seems reasonable and probably worth making as general
cleanup.

Eric

> Signed-off-by: Vitaly Kuznetsov <vitty@...linux.ru>
> ---
>  fs/sysfs/mount.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index 4974995..9d56fdd 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -36,7 +36,7 @@ struct sysfs_dirent sysfs_root = {
>         .s_name         = "",
>         .s_count        = ATOMIC_INIT(1),
>         .s_flags        = SYSFS_DIR,
> -       .s_mode         = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO,
> +       .s_mode         = S_IFDIR | S_IRUGO | S_IXUGO,
>         .s_ino          = 1,
>  };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/