| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201112201118.24342.oneukum@suse.de> Date: Tue, 20 Dec 2011 11:18:24 +0100 From: Oliver Neukum <oneukum@...e.de> To: Daniel Kurtz <djkurtz@...omium.org> Cc: jkosina@...e.cz, bleung@...omium.org, stern@...land.harvard.edu, olofj@...omium.org, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue Am Dienstag, 20. Dezember 2011, 11:12:37 schrieb Daniel Kurtz: > > > Could you please be more specific about what this patch breaks and > > > perhaps give some guidance on how to fix it? > > > > It breaks nothing. It just continues a bug and I assumed it was not present. > > Basically the work queue must do nothing after pre_reset() and post_reset() > > ought to rerun the work in case some request came down during that time. > > So, is this an Ack for this patchset? > Can we fix any existing races in later patches? Very well. You are fixing a bad bug and not making matters worse. Acked-by: Oliver Neukum <oneukum@...e.de> Regards Oliver -- - - - SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany - - - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists