linux-kernel - Re: [PATCH v4 4/4] usb: simplify hdrc configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111220110404.GD31842@legolas.emea.dhcp.ti.com>
Date:	Tue, 20 Dec 2011 13:04:06 +0200
From:	Felipe Balbi <balbi@...com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Felipe Balbi <balbi@...com>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Pavankumar Kondeti <pkondeti@...eaurora.org>,
	Benoit Goby <benoit@...roid.com>,
	Li Yang <leoli@...escale.com>,
	"open list:MUSB MULTIPOINT H..." <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v4 4/4] usb: simplify hdrc configuration

Hi,

On Tue, Dec 20, 2011 at 03:15:17AM +0200, Felipe Contreras wrote:
> HDRC requires either NOP_USB_XCEIV or TWLX030_USB, and it selects the

that's not entirely true. Like any USB Link controller, MUSB needs a PHY
to work, but can be any off-the-shelf PHY. Nokia has used isp1704 and
isp1707 for instance. I guess Nokia also used tusb1211 and none of them
are listed there.

I would rather remove all the dependencies because the person compiling
the kernel should know that a Link needs a PHY. Maybe add a note
somewhere stating that you should enable the PHY driver for your
platform ?

> right one based on architectures or board.
> 
> However, many OMAP2+ boards are excluded from this selection and it's
> possible to have a configuration with no transceiver, so HDRC doesn't
> work.
> 
> What we need is a 'soft' dependency, and this can be achieved by
> transforming the 'selects' to 'default'. This way we can have sane
> defaults for all OMAP2+ boards, and the ones that need NOP can just
> specify that manually.
> 
> This simplifies the config from:
> 
>      CONFIG_USB=y
>      CONFIG_TWL4030_CORE=y
>      CONFIG_TWL4030_USB=y
> 
> To:
> 
>      CONFIG_USB=y
>      CONFIG_TWL4030_CORE=y
> 
> And so on.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> ---
>  drivers/usb/musb/Kconfig |    4 +---
>  drivers/usb/otg/Kconfig  |    3 +++
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index 07a0346..b60d3a5 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -7,9 +7,7 @@
>  config USB_MUSB_HDRC
>  	depends on USB && USB_GADGET
>  	depends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 && !BF523))
> -	select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
> -	select TWL4030_USB if MACH_OMAP_3430SDP
> -	select TWL6030_USB if MACH_OMAP_4430SDP || MACH_OMAP4_PANDA
> +	depends on (NOP_USB_XCEIV || TWL4030_USB || TWL6030_USB)

on commit log, you said you were converting select to default, but here
you're converting select to depend. I have just added a patch allowing
musb to compile on all ARCHes and cannot take this step backwards.
Sorry. Any chance to resping this patch in another way ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)