[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111220021722.GA8257@opensource.wolfsonmicro.com>
Date: Tue, 20 Dec 2011 02:17:23 +0000
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Felipe Contreras <felipe.contreras@...il.com>
Cc: linux-kernel@...r.kernel.org,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Felipe Balbi <balbi@...com>,
Vladimir Zapolskiy <vz@...ia.com>, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH v4 3/4] regulator: simplify twl4030 config
On Tue, Dec 20, 2011 at 04:04:14AM +0200, Felipe Contreras wrote:
> On Tue, Dec 20, 2011 at 3:53 AM, Mark Brown
> > Yes, of course. Half the point in having subsystems and standard ways
> > of doing things is so that when we look at things we've got a reasonable
> > idea as to what they're supposed to be doing and people looking at the
> > code can figure out what's going on. We don't want people to have to
> > play guessing games about this stuff.
> Of course... *ideally*, but we are not there right now.
We pretty much were, but this patch has changelog which says "I've got a
cool new way of doing things for this one driver!" which clearly applies
to other drivers. I wouldn't mind a patch which does this for all MFDs
(though I really do think it should be applied to most subsystems) but
doing it for one driver isn't great.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists