linux-kernel - RE: [PATCH] intel-iommu: Add device info into list before doing context mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BC00F5384FCFC9499AF06F92E8B78A9E28904879BF@shsmsx502.ccr.corp.intel.com>
Date:	Wed, 21 Dec 2011 10:04:28 +0800
From:	"Hao, Xudong" <xudong.hao@...el.com>
To:	Chris Wright <chrisw@...s-sol.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>
CC:	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"Zhang, Xiantao" <xiantao.zhang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: RE: [PATCH] intel-iommu: Add device info into list before doing
 context mapping

Yes, Chris, thanks your comments.
How about this one?

---
 drivers/iommu/intel-iommu.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a004c39..0fc5efd 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -2264,12 +2264,6 @@ static int domain_add_dev_info(struct dmar_domain *domain,
    if (!info)
        return -ENOMEM;

-   ret = domain_context_mapping(domain, pdev, translation);
-   if (ret) {
-       free_devinfo_mem(info);
-       return ret;
-   }
-
    info->segment = pci_domain_nr(pdev->bus);
    info->bus = pdev->bus->number;
    info->devfn = pdev->devfn;
@@ -2282,6 +2276,16 @@ static int domain_add_dev_info(struct dmar_domain *domain,
    pdev->dev.archdata.iommu = info;
    spin_unlock_irqrestore(&device_domain_lock, flags);

+   ret = domain_context_mapping(domain, pdev, translation);
+   if (ret) {
+       spin_lock_irqsave(&device_domain_lock, flags);
+       list_del(&info->link);
+       list_del(&info->global);
+       spin_unlock_irqrestore(&device_domain_lock, flags);
+       free_devinfo_mem(info);
+       return ret;
+   }
+
    return 0;
 }

> -----Original Message-----
> From: Chris Wright [mailto:chrisw@...s-sol.org]
> Sent: Wednesday, December 21, 2011 12:08 AM
> To: Hao, Xudong
> Cc: iommu@...ts.linux-foundation.org; dwmw2@...radead.org; Zhang, Xiantao;
> linux-kernel@...r.kernel.org; kvm@...r.kernel.org
> Subject: Re: [PATCH] intel-iommu: Add device info into list before doing context
> mapping
> 
> * Hao, Xudong (xudong.hao@...el.com) wrote:
> > @@ -2282,6 +2276,14 @@ static int domain_add_dev_info(struct
> dmar_domain *domain,
> >  	pdev->dev.archdata.iommu = info;
> >  	spin_unlock_irqrestore(&device_domain_lock, flags);
> >
> > +	ret = domain_context_mapping(domain, pdev, translation);
> > +	if (ret) {
> > +		list_del(&info->link);
> > +		list_del(&info->global);
> 
> At the very least, this is not correct locking.
> 
> > +		free_devinfo_mem(info);
> > +		return ret;
> > +	}
> > +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/