linux-kernel - Re: [PATCH 2/3] cgroup: remove double-checking locking from attach_task_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111223021333.GM13529@google.com>
Date:	Thu, 22 Dec 2011 18:13:33 -0800
From:	Mandeep Singh Baines <msb@...omium.org>
To:	Mandeep Singh Baines <msb@...omium.org>
Cc:	Tejun Heo <tj@...nel.org>, Li Zefan <lizf@...fujitsu.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Menage <paul@...lmenage.org>
Subject: Re: [PATCH 2/3] cgroup: remove double-checking locking from
 attach_task_by_pid

This is not going to work. Will fix up and resend. Need to goto
the top as suggested by Tejun.

Mandeep Singh Baines (msb@...omium.org) wrote:
> By reading group_leader after taking the threadgroup_lock, we can
> avoid the double-check locking. This removes the return of
> -EAGAIN so we can cleanup cgroup_procs_write at the same time.
> 
> The suggestion was made here:
> 
> https://lkml.org/lkml/2011/12/22/371
> 
> Suggested-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Mandeep Singh Baines <msb@...omium.org>
> Cc: Li Zefan <lizf@...fujitsu.com>
> Cc: containers@...ts.linux-foundation.org
> Cc: cgroups@...r.kernel.org
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Paul Menage <paul@...lmenage.org>
> ---
>  kernel/cgroup.c |   40 ++++++----------------------------------
>  1 files changed, 6 insertions(+), 34 deletions(-)
> 
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 032139d..a5f7d1b 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -2234,9 +2234,6 @@ static int attach_task_by_pid(struct cgroup *cgrp, u64 pid, bool threadgroup)
>  			ret= -ESRCH;
>  			goto out_unlock_cgroup;
>  		}
> -		/* we check later for a group_leader race with de_thread */
> -		if (threadgroup)
> -			tsk = tsk->group_leader;
>  		/*
>  		 * even if we're attaching all tasks in the thread group, we
>  		 * only need to check permissions on one of them.
> @@ -2252,33 +2249,17 @@ static int attach_task_by_pid(struct cgroup *cgrp, u64 pid, bool threadgroup)
>  		get_task_struct(tsk);
>  		rcu_read_unlock();
>  	} else {
> -		if (threadgroup)
> -			tsk = current->group_leader;
> -		else
> -			tsk = current;
> +		tsk = current;
>  		get_task_struct(tsk);
>  	}
>  
>  	threadgroup_lock(tsk);
> -
> -	if (threadgroup) {
> -		if (!thread_group_leader(tsk)) {
> -			/*
> -			 * a race with de_thread from another thread's exec()
> -			 * may strip us of our leadership, if this happens,
> -			 * there is no choice but to throw this task away and
> -			 * try again (from cgroup_procs_write); this is
> -			 * "double-double-toil-and-trouble-check locking".
> -			 */
> -			ret = -EAGAIN;
> -			goto out_unlock_threadgroup;
> -		}
> -		ret = cgroup_attach_proc(cgrp, tsk);
> -	} else
> +	if (threadgroup)
> +		ret = cgroup_attach_proc(cgrp, tsk->group_leader);
> +	else
>  		ret = cgroup_attach_task(cgrp, tsk);
> -
> -out_unlock_threadgroup:
>  	threadgroup_unlock(tsk);
> +
>  	put_task_struct(tsk);
>  out_unlock_cgroup:
>  	cgroup_unlock();
> @@ -2292,16 +2273,7 @@ static int cgroup_tasks_write(struct cgroup *cgrp, struct cftype *cft, u64 pid)
>  
>  static int cgroup_procs_write(struct cgroup *cgrp, struct cftype *cft, u64 tgid)
>  {
> -	int ret;
> -	do {
> -		/*
> -		 * attach_proc fails with -EAGAIN if threadgroup leadership
> -		 * changes in the middle of the operation, in which case we need
> -		 * to find the task_struct for the new leader and start over.
> -		 */
> -		ret = attach_task_by_pid(cgrp, tgid, true);
> -	} while (ret == -EAGAIN);
> -	return ret;
> +	return attach_task_by_pid(cgrp, tgid, true);
>  }
>  
>  /**
> -- 
> 1.7.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/