linux-kernel - Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111223062649.GD21994@1wt.eu>
Date:	Fri, 23 Dec 2011 07:26:49 +0100
From:	Willy Tarreau <w@....eu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
	security@...nel.org, pmatouse@...hat.com, agk@...hat.com,
	jbottomley@...allels.com, mchristi@...hat.com, msnitzer@...hat.com
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Dec 22, 2011 at 04:07:46PM -0800, Linus Torvalds wrote:
> For example, I just traced it, and "eject /dev/sdb1" does a CDROMEJECT
> ioctl when used as the root user. I haven't tested the patch, but just
> reading it, I'd expect it to break that.
> 
> And that's the *natural* way to eject a mounted device. Look at the
> USB memory sticks you have. They are almost all partitioned to have
> one partition, and that one partition doesn't cover the whole device.
> And it's that one partition you use to interact with it - it's what
> you mount, and what you eject.

Call me dumb, but why would someone use "eject" on a non-physically
ejectable device such as a memory stick ? I use it on CDs, I've used
it on Sun floppy drives, but USB memory stick ??? After the umount,
I just have to pull it from the plug and that's all. I don't catch
what an eject command can bring me on top of that :-/

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/