linux-kernel - Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxnOwkquH8tirqJnM_KTcavAejY8drL11jy2S+2PXmZuw@mail.gmail.com>
Date:	Fri, 23 Dec 2011 01:22:24 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Willy Tarreau <w@....eu>
Cc:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
	security@...nel.org, pmatouse@...hat.com, agk@...hat.com,
	jbottomley@...allels.com, mchristi@...hat.com, msnitzer@...hat.com
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Dec 22, 2011 at 10:26 PM, Willy Tarreau <w@....eu> wrote:
>
> Call me dumb, but why would someone use "eject" on a non-physically
> ejectable device such as a memory stick ?

Perhaps because that's the operation that works everywhere and is the
simplest one?

Just look at the icon on your desktop - it probably has "Eject" above
the silly "Safely remove drive" when you right-click it. It has for
me.

And I've taught myself (and my wife) to always eject media before
removing them. I don't "unmount" them, because then for cdroms I need
to first unmount them and then eject them. Or I'd need to do different
operations for different devices. Both of which are just stupid.

So yes, I claim that "eject" is actually the *natural* thing to do
before you physically remove the medium, because it works across
different media.

But more importantly, we don't break what works. So what the f&^k was
the point of even asking? THAT was the "dumb" thing here.

                                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/