linux-kernel - Re: [PATCH] move get_idle_time , get_iowait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EF45309.7060005@parallels.com>
Date:	Fri, 23 Dec 2011 14:08:09 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Glauber Costa <glommer@...allels.com>
CC:	<linux-kernel@...r.kernel.org>, <a.p.zijlstra@...llo.nl>,
	<pjt@...gle.com>, <devel@...nvz.org>,
	Michal Hocko <mhocko@...e.cz>, Dave Jones <davej@...hat.com>,
	Arnd Bergmann <arnd@...db.de>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c

On 12/12/2011 01:31 PM, Glauber Costa wrote:
> In commit a25cac5198 we changed the way we calculate idle and iowait
> for /proc/stat displaying purposes. However, this same information
> is also displayed in /proc/uptime. These values can now be inconsistent.
>
> So I propose we draw both idle values from the same place. In theory,
> we only need to do it for get_idle_time(). get_iowait_time() is moved
> as well for consistency only.
>
> I moved the functions to sched/core.c so it can live among its other
> friends like nr_iowait(), etc.
>

You guys have any opinions on this ?
I see that Michal got another fix for this in stat.c already, so I'd 
have to respin this one anyway. Just let me know if this is wanted

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/