linux-kernel - Re: [PATCH -next] debugfs: add missing #ifdef HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111227142544.GA30402@mail.gnudd.com>
Date:	Tue, 27 Dec 2011 15:25:44 +0100
From:	Alessandro Rubini <rubini@...dd.com>
To:	heiko.carstens@...ibm.com
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM

> "debugfs: add tools to printk 32-bit registers" adds new functions
> which rely on IOMEM functionality which is not present on all
> architectures and therefore result in compile errors:

Ok, my fault. I was thinking everybody has it.

Acked-by: Alessandro Rubini <rubini@...dd.com>

(on the other hand, maybe the header should have it as well? I hate
ifdef so I'd better avoid it, but I don't know what the policy is in
this case: compile-error for implicit declaration or link error for
missing symbol?  -- maybe a comment in the header is suitable?).

/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/