linux-kernel - Re: [PATCH -next] debugfs: add missing #ifdef HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120104004452.GA22949@kroah.com>
Date:	Tue, 3 Jan 2012 16:44:52 -0800
From:	Greg KH <greg@...ah.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Alessandro Rubini <rubini@...dd.com>
Subject: Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM

On Tue, Dec 27, 2011 at 03:08:28PM +0100, Heiko Carstens wrote:
> "debugfs: add tools to printk 32-bit registers" adds new functions which rely
> on IOMEM functionality which is not present on all architectures and therefore
> result in compile errors:
> 
> fs/debugfs/file.c: In function 'debugfs_print_regs32':
> fs/debugfs/file.c:561:7: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Who does not have readl()?  Surely there should be a .h file we are just
missing to include?

> Add an #ifdef CONFIG_HAS_IOMEM to fix this

I guess this is ok, thanks for the patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/