linux-kernel - Re: [Fwd: [patch] intel_idle: Delete meaningless local_irq_disable() call in intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1325032032.3860.17.camel@ymzhang>
Date:	Wed, 28 Dec 2011 08:27:12 +0800
From:	Yanmin Zhang <yanmin_zhang@...ux.intel.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, shaohua.li@...el.com,
	len.brown@...el.com, mingmingx.zhang@...el.com
Subject: Re: [Fwd: [patch] intel_idle: Delete meaningless
 local_irq_disable() call in intel_idle.c.]

On Tue, 2011-12-27 at 16:10 -0800, Andrew Morton wrote:
> On Mon, 26 Dec 2011 09:28:20 +0800
> Yanmin Zhang <yanmin_zhang@...ux.intel.com> wrote:
> 
> > Andrew,
> > 
> > Would you like to accept the patch into your testing tree?
> 
> hm, that's three indel_idle patches which I have now.  Someone wake up
> lenb!
> 
> > intel_idle.c is a bit misleading in a sense that local_irq_disable,it
> 

> I'd suggest adding this as well:
Agree. It'll be clearer.

> 
> --- a/drivers/idle/intel_idle.c~drivers-idle-intel_idlec-remove-redundant-local_irq_disable-call-fix
> +++ a/drivers/idle/intel_idle.c
> @@ -232,6 +232,7 @@ static int get_driver_data(int cstate)
>   * @drv: cpuidle driver
>   * @index: index of cpuidle state
>   *
> + * Must be called under local_irq_disable().
>   */
>  static int intel_idle(struct cpuidle_device *dev,
>  		struct cpuidle_driver *drv, int index)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/