linux-kernel - Re: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F021784.7070802@gmail.com>
Date:	Tue, 03 Jan 2012 07:45:56 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Ravishankar karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
CC:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com,
	joe@...ches.com, valdis.kletnieks@...edu, jj@...osbits.net
Subject: Re: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL
 issue in ni_mio_cs.c.

On 03/01/12 00:17, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the ni_mio_cs.c file that fixes up a initialise
> statics to 0 or NULL warning found by the checkpatch.pl tool.
>
> Breaks the build.

Greg was pointing out that your previous patch broke the build. He did
not literally mean that you should add the above message to the commit
log. The fact that you did, seemingly thinking that doing so was
correct, is just ... scary.

> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
>  drivers/staging/comedi/drivers/ni_mio_cs.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 53ec24b..cb3d08b 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -258,7 +258,7 @@ static void mio_cs_config(struct pcmcia_device *link);
>  static void cs_release(struct pcmcia_device *link);
>  static void cs_detach(struct pcmcia_device *);
>  
> -static struct pcmcia_device *cur_dev = NULL;
> +static struct pcmcia_device *cur_dev;
>  
>  static int cs_attach(struct pcmcia_device *link)
>  {
> @@ -351,6 +351,8 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
>  	       dev->minor, dev->driver->driver_name, dev->iobase, irq);
>  
> +
> +

Why this change?

>  #if 0
>  	{
>  		int i;
> @@ -400,7 +402,7 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  }
>  
>  static int ni_getboardtype(struct comedi_device *dev,
> -			   struct pcmcia_device *link)
> +		struct pcmcia_device *link)

Why this change?

>  {
>  	int i;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/