linux-kernel - Re: [PATCH 5/6] Staging: comedi: fix line over 80 character issue in daqboard2000.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F0217D6.2070705@gmail.com>
Date:	Tue, 03 Jan 2012 07:47:18 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Ravishankar karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
CC:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com,
	joe@...ches.com, valdis.kletnieks@...edu, jj@...osbits.net
Subject: Re: [PATCH 5/6] Staging: comedi: fix line over 80 character issue
 in daqboard2000.c

On 03/01/12 00:10, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> line over 80 character warning found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
>  drivers/staging/comedi/drivers/daqboard2000.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index e61c6a8..3550c6a 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -414,7 +414,7 @@ static int daqboard2000_ai_insn_read(struct comedi_device *dev,
>  
>  	/* If pacer clock is not set to some high value (> 10 us), we
>  	   risk multiple samples to be put into the result FIFO. */
> -	fpga->acqPacerClockDivLow = 1000000;	/* 1 second, should be long enough */
> +	/* 1 second, should be long enough */

You broke the driver here.

>  	fpga->acqPacerClockDivHigh = 0;
>  
>  	gain = CR_RANGE(insn->chanspec);
> @@ -526,7 +526,8 @@ static void daqboard2000_pulseProgPin(struct comedi_device *dev)
>  	writel(DAQBOARD2000_SECRProgPinHi, devpriv->plx + 0x6c);
>  	udelay(10000);
>  	writel(DAQBOARD2000_SECRProgPinLo, devpriv->plx + 0x6c);
> -	udelay(10000);		/* Not in the original code, but I like symmetry... */
> +	/* Not in the original code, but I like symmetry... */
> +	udelay(10000);
>  }
>  
>  static int daqboard2000_pollCPLD(struct comedi_device *dev, int mask)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/