linux-kernel - Re: [PATCH] ARM: Remove BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jan 2012 11:50:13 -0800
From:	Simon Glass <sjg@...omium.org>
To:	Olof Johansson <olof@...om.net>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Olof Johansson <olofj@...omium.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Ben Hutchings <ben@...adent.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h

Hi Olof,

On Tue, Jan 3, 2012 at 11:39 AM, Olof Johansson <olof@...om.net> wrote:
> On Tue, Jan 3, 2012 at 10:44 AM, Simon Glass <sjg@...omium.org> wrote:
>> BUILD_BUG_ON is defined in linux/kernel.h but that is not included by the
>> asm/bug.h header which uses it. This causes a build error:
>>
>> ...include/linux/mtd/map.h: In function 'inline_map_read':
>> ...include/linux/mtd/map.h:408:3: error: implicit declaration of function
>> 'BUILD_BUG_ON' [-Werror=implicit-function-declaration]
>>
>> The check is not essential and is not present for other architectures, so
>> just remove it.
>>
>> Signed-off-by: Simon Glass <sjg@...omium.org>
>
> Acked-by: Olof Johansson <olof@...om.net>
>
> Simon, have you sent it to Russell's patch tracker? If not, please do.

Done

Regards,
Simon

>
>
> -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/