linux-kernel - Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F04D62B.50107@windriver.com>
Date:	Wed, 4 Jan 2012 17:43:55 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	<alan@...ux.intel.com>, <gregkh@...e.de>,
	<linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to
 tty/serial/

On 12-01-04 05:01 PM, Alan Cox wrote:
> On Wed,  4 Jan 2012 15:01:27 -0500
> Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
> 
>> The commit ab4382d27412e7e3e7c936e8d50d8888dfac3df8,
>>
>>    "tty: move drivers/serial/ to drivers/tty/serial/"
>>
>> put most of the serial drivers together in one place, but the ones
>> that were hiding in drivers/char didn't get picked up in that change.
>>
>> They did get moved in commit a6afd9f3e819de4795fcd356e5bfad446e4323f2
>>
>>    "tty: move a number of tty drivers from drivers/char/ to drivers/tty/"
>>
>> but there was no distinction of serial vs. non-serial in the above.
>>
>> Here we take the remaining serial drivers (mostly legacy multiport
>> drivers) and put them alongside all the others in tty/serial/ dir.
>>
>> We can drop SERIAL_NONSTANDARD's dependency on HAS_IOMEM, since the
>> encompassing menu block already has that dependency called out.
> 
> NAK
> 
> The tty/serial directory is the stuff using serial_core. I'm not averse
> to moving the others down a layer into more appropriate places but its
> already too crowded and in need of re-ordering (eg tty/serial/8250/...
> might be an improvement)

OK, I can do 8250.  What do you have in mind for the legacy multiport
drivers then, leave them as-in in drivers/tty or another subdir just
for them?

Thanks,
P.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/