linux-kernel - Re: [PATCH 4/5] x86: efi: add basic error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1325762519.3635.22.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Thu, 05 Jan 2012 11:21:59 +0000
From:	Matt Fleming <matt.fleming@...el.com>
To:	Olof Johansson <olof@...om.net>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Subject: Re: [PATCH 4/5] x86: efi: add basic error handling

On Tue, 2012-01-03 at 09:11 -0800, Olof Johansson wrote:
> It's not perfect, but way better than before. Mark efi_enabled as false in
> case of error and at least stop dereferencing pointers that are known to
> be invalid.
> 
> The only significant missing piece is the lack of undoing the
> memblock_reserve of the memory that efi marks as in use. On the other
> hand, it's not a large amount of memory, and leaving it unavailable for
> system use should be the safer choice anyway.
> 
> Signed-off-by: Olof Johansson <olof@...om.net>
> ---
>  arch/x86/platform/efi/efi.c |   89 ++++++++++++++++++++++++++++--------------
>  1 files changed, 59 insertions(+), 30 deletions(-)

Seems straight forward and better than what was there previously. Have
you tested this error handling?

Acked-by: Matt Fleming <matt.fleming@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/