linux-kernel - Re: [PATCH block:for-3.3/core] block: disable ELEVATOR_INSERT_SORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1325823545.22361.526.camel@sli10-conroe>
Date:	Fri, 06 Jan 2012 12:19:05 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jens Axboe <axboe@...nel.dk>, Hugh Dickins <hughd@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH block:for-3.3/core] block: disable
 ELEVATOR_INSERT_SORT_MERGE

On Thu, 2012-01-05 at 19:52 -0800, Tejun Heo wrote:
> 5e84ea3a9c "block: attempt to merge with existing requests on plug
> flush" added support for merging requests on plug flush and 274193224c
> "block: recursive merge requests" added recursive merging.
> 
> Because these mergings happen before the request is inserted on the
> elevator, the usual elv_latter/former_request() can't be used to
> locate merge candidates.  It instead used bio merging mechanism -
> last_merge hint and rqhash; unfortunately, this means that the
> elevator doesn't have a say in which are allowed to merge and which
> aren't.
> 
> For cfq, this resulted in merges across different cfqq's which led to
> crashes as requests jump between different cfqq's unexpectedly.
> 
> Proper solution would be improving merge mechanism such that we can
> always query elevator to find out merge candidates and remove rqhash;
> however, the merge window is already upon us.  Disable
> INSERT_SORT_MERGE for now.
> 
> For detailed discussion of the bug:
> 
>  http://thread.gmane.org/gmane.linux.kernel.next/20064/focus=20159
> 
this is overkill. when plug is added, we found huge performance
regression, that's why we add INSERT_SORT_MERGE.

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/