linux-kernel - Re: [PATCH block:for-3.3/core] block: disable ELEVATOR_INSERT_SORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YPUgK4J6j1Gme9O9HeL7GrwnJU8QTVKbVLA9cEXPQ1kag@mail.gmail.com>
Date:	Thu, 5 Jan 2012 20:38:07 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	Jens Axboe <axboe@...nel.dk>, Hugh Dickins <hughd@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH block:for-3.3/core] block: disable ELEVATOR_INSERT_SORT_MERGE

Hello,

On Thu, Jan 5, 2012 at 8:19 PM, Shaohua Li <shaohua.li@...el.com> wrote:
>> For detailed discussion of the bug:
>>
>>  http://thread.gmane.org/gmane.linux.kernel.next/20064/focus=20159
>>
> this is overkill. when plug is added, we found huge performance
> regression, that's why we add INSERT_SORT_MERGE.

With what workload? I suspect most of the improvements is from merging
across different cfqqs, no? The whole recursive thing can't be very
useful if cross-cfqq merging isn't allowed. Maybe there are specific
cases where last_merge hint merging can be specially effective. I
don't know. Regardless, this is an apparent bug and the block tree
will be pushed mainline pretty soon. If necessary, fix it better
later. Doing complex things inside merge window usually isn't a good
idea.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/