linux-kernel - Re: [PATCH 4/6] x86: initial support for sta2x11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1325930757.14763.4.camel@joe2Laptop>
Date:	Sat, 07 Jan 2012 02:05:57 -0800
From:	Joe Perches <joe@...ches.com>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] x86: initial support for sta2x11

On Sat, 2012-01-07 at 09:22 +0100, Alessandro Rubini wrote:
> > or __func__
> I don't understand. No size? Or you typoed and meant pr_fmt defined above?

I meant that outputting __func__ (in this case
sta2x11_new_instance) doesn't gain much useful
information and generally isn't necessary.

> >> +	uint32_t v[2]; /* used as a string... */
> > less than pretty.
> Sure. But it's informative. Do you prefer a union?

Not really.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/