[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120108161212.GD21765@n2100.arm.linux.org.uk>
Date: Sun, 8 Jan 2012 16:12:12 +0000
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: Gilad Ben-Yossef <gilad@...yossef.com>
Cc: linux-kernel@...r.kernel.org, Will Deacon <will.deacon@....com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
Grant Likely <grant.likely@...retlab.ca>,
Rob Herring <rob.herring@...xeda.com>,
linux-arm-kernel@...ts.infradead.org,
devicetree-discuss@...ts.ozlabs.org
Subject: Re: [RFC PATCH v2 1/9] arm: avoid using on_each_cpu hard coded ret
value
On Sun, Jan 08, 2012 at 03:32:21PM +0200, Gilad Ben-Yossef wrote:
> on_each_cpu always returns a hard coded return code of zero.
>
> Removing all tests based on this return value saves run time
> cycles for compares and code bloat for branches.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Reviewed-by: Michal Nazarewicz <mina86@...a86.com>
> CC: Will Deacon <will.deacon@....com>
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Paul Mackerras <paulus@...ba.org>
> CC: Ingo Molnar <mingo@...e.hu>
> CC: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> CC: Russell King <linux@....linux.org.uk>
Reviewed-by: Russell King <rmk+kernel@....linux.org.uk>
> CC: Grant Likely <grant.likely@...retlab.ca>
> CC: Rob Herring <rob.herring@...xeda.com>
> CC: linux-arm-kernel@...ts.infradead.org
> CC: devicetree-discuss@...ts.ozlabs.org
> ---
> arch/arm/kernel/perf_event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 5bb91bf..6e9acb7 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -616,7 +616,7 @@ static int __init
> cpu_pmu_reset(void)
> {
> if (cpu_pmu && cpu_pmu->reset)
> - return on_each_cpu(cpu_pmu->reset, NULL, 1);
> + on_each_cpu(cpu_pmu->reset, NULL, 1);
There's not much to review here...
Thanks.
> return 0;
> }
> arch_initcall(cpu_pmu_reset);
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists